Bug 99771

Summary: [WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebKit2Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2012-10-18 15:53:50 PDT
And that is getting pretty annoying. Let's fix that.
Attachments
Patch (50.31 KB, patch)
2012-10-18 16:10 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (50.31 KB, patch)
2012-10-18 16:37 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (53.73 KB, patch)
2012-10-18 19:20 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-18 16:10:42 PDT
Created attachment 169499 [details] Patch
Early Warning System Bot
Comment 2 2012-10-18 16:19:05 PDT
Comment on attachment 169499 [details] Patch Attachment 169499 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14464179
Benjamin Poulain
Comment 3 2012-10-18 16:37:38 PDT
Created attachment 169504 [details] Patch
Anders Carlsson
Comment 4 2012-10-18 18:36:57 PDT
Comment on attachment 169504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169504&action=review > Source/WebKit2/Platform/CoreIPC/MessageID.h:115 > +#if ENABLE(PLUGIN_PROCESS) > // Messages sent by the UI process to the shared worker process. > MessageClassSharedWorkerProcess, > +#endif // ENABLE(PLUGIN_PROCESS) I think this should be ENABLE(SHARED_WORKER_PROCESS). > Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h:51 > PluginProcess, Maybe PluginProcess should be surrounded with #ifdefs too.
Benjamin Poulain
Comment 5 2012-10-18 19:20:53 PDT
Created attachment 169534 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-10-18 19:43:56 PDT
Comment on attachment 169534 [details] Patch for landing Clearing flags on attachment: 169534 Committed r131844: <http://trac.webkit.org/changeset/131844>
WebKit Review Bot
Comment 7 2012-10-18 19:44:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.