Bug 99770

Summary: Mac WTF build checks dependencies before copying header files
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: Tools / TestsAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 99739    
Attachments:
Description Flags
Fixed a couple of problems from original checkin
mrowe: review-
Updated patch mrowe: review+

Michael Saboff
Reported 2012-10-18 15:51:57 PDT
XCode checks dependencies as the first phase of building. The second step for building WTF is to move the WTF header files to the derived location. This move can impact the dependency outcome causing the build to fail.
Attachments
Fixed a couple of problems from original checkin (3.59 KB, patch)
2012-10-18 17:17 PDT, Michael Saboff 		mrowe: review-
DetailsFormatted DiffDiff
Updated patch (7.66 KB, patch)
2012-10-18 17:46 PDT, Michael Saboff 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-18 16:06:56 PDT
Committed r131819: <http://trac.webkit.org/changeset/131819>
Michael Saboff
Comment 2 2012-10-18 17:14:35 PDT
Mark says this isn't quite right.
Michael Saboff
Comment 3 2012-10-18 17:17:27 PDT
Created attachment 169509 [details] Fixed a couple of problems from original checkin
Mark Rowe (bdash)
Comment 4 2012-10-18 17:25:07 PDT
Comment on attachment 169509 [details] Fixed a couple of problems from original checkin Beyond this, you should create a new CopyWTFHeaders.xcconfig file for this target and move the bits that this target needs that the WTF no longer needs (PRIVATE_HEADERS_FOLDER_PATH / INSTALLHDRS_SCRIPT_PHASE, I think) out of WTF.xcconfig. If you do that as well then I think that'll address all of my complaints.
Michael Saboff
Comment 5 2012-10-18 17:46:34 PDT
Created attachment 169518 [details] Updated patch
Mark Rowe (bdash)
Comment 6 2012-10-18 17:48:05 PDT
Comment on attachment 169518 [details] Updated patch Only minor nit is that it should be CopyWTFHeaders.xcconfig, with the trailing s. If it's a pain to change it, don't worry about it!
Michael Saboff
Comment 7 2012-10-18 18:04:39 PDT
Committed r131833: <http://trac.webkit.org/changeset/131833>
Note You need to log in before you can comment on or make changes to this bug.