Bug 99737

Summary: Page should be removed from the cache right after restore was called
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, ddkilzer, japhet, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Proposed fix 0.1
abarth: review-
Proposed fix 0.2 none

Dima Gorbik
Reported 2012-10-18 11:20:53 PDT
The pageCache is inconsistent after the restoration because the cachedFrame is being nulled, but the page is still in the Cache. We should remove the page from the cache faster.
Attachments
Proposed fix 0.1 (2.46 KB, patch)
2012-10-18 17:20 PDT, Dima Gorbik 		abarth: review-
DetailsFormatted DiffDiff
Proposed fix 0.2 (2.67 KB, patch)
2012-10-19 15:48 PDT, Dima Gorbik 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dima Gorbik
Comment 1 2012-10-18 17:20:22 PDT
Created attachment 169511 [details] Proposed fix 0.1
Adam Barth
Comment 2 2012-10-18 17:29:13 PDT
Comment on attachment 169511 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=169511&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Can we write a test for this issue? FrameLoader, especially interactions with PageCache, are woefully under tested.
Dima Gorbik
Comment 3 2012-10-19 15:47:41 PDT
Unfortunately this was noticed in a custom application and we have no reasonable way to test its behavior in LayoutTests. But the current tests that exercise the page cache do pass.
Dima Gorbik
Comment 4 2012-10-19 15:48:20 PDT
Created attachment 169714 [details] Proposed fix 0.2
Brady Eidson
Comment 5 2012-10-19 15:52:33 PDT
Comment on attachment 169714 [details] Proposed fix 0.2 It's unfortunately we can't get a targeted test here... But I think this is a good change worth taking. No regressions on existing tests is good enough for me here.
Adam Barth
Comment 6 2012-10-19 15:59:40 PDT
Despite the discussion in <http://lists.webkit.org/pipermail/webkit-dev/2009-October/010303.html>, I agree that this is the right course of action here.
WebKit Review Bot
Comment 7 2012-10-19 16:13:15 PDT
Comment on attachment 169714 [details] Proposed fix 0.2 Clearing flags on attachment: 169714 Committed r131953: <http://trac.webkit.org/changeset/131953>
WebKit Review Bot
Comment 8 2012-10-19 16:13:19 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 9 2012-11-02 11:53:25 PDT
<rdar://problem/12438412>
Note You need to log in before you can comment on or make changes to this bug.