Bug 99671 – Refactor picker tests to avoid flakiness and share code

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Refactor picker tests to avoid flakiness and share code

[Keishi Hattori]

Created attachment 169535 [details]
Patch

[Kent Tamura]

Comment on attachment 169535 [details]
Patch

Please rebase.

[Keishi Hattori]

Created attachment 169540 [details]
Patch

[WebKit Review Bot]

Comment on attachment 169540 [details]
Patch

Attachment 169540 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14455367

New failing tests:
platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html
platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html

[Kent Tamura]

Comment on attachment 169540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169540&action=review

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:22
> +openPicker(document.getElementById('date'), finishTest);
> +
>  function finishTest() {
> -    popupWindow.removeEventListener('resize', finishTest);
> -    setTimeout(function() { testRunner.notifyDone(); }, 0);
> +    finishJSTest();

We can remove finishTest by openPicker(document...., finishJSTest);

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html:22
> +openPicker(document.getElementById('date'), finishTest);
> +
>  function finishTest() {
> -    console.log(popupWindow.pagePopupController);
> -    popupWindow.removeEventListener('resize', finishTest);
> -    setTimeout(function() {testRunner.notifyDone();}, 0);
> +    finishJSTest();
>  }

ditto.

> LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html:24
> +openPicker(document.getElementById('color'), test);
>  
> -document.getElementById('color').focus();
> -if (window.eventSender)
> -    eventSender.keyDown(' ');
> -var pickerWindow = document.getElementById('mock-page-popup').contentWindow;
> -pickerWindow.onresize = function() {
> -    testRunner.notifyDone();
> +function test() {
> +    finishJSTest();
>  }

ditto.

> LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html:30
> +openPicker(document.getElementById('color'), test);
>  
> -document.getElementById('color').focus();
> -if (window.eventSender)
> -    eventSender.keyDown(' ');
> -var pickerWindow = document.getElementById('mock-page-popup').contentWindow;
> -pickerWindow.onresize = function() {
> -    testRunner.notifyDone();
> +function test() {
> +    finishJSTest();
>  }

ditto.

> LayoutTests/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html:59
> +openPicker(document.getElementById('color'), test);
>  
> -document.getElementById('color').focus();
> -if (window.eventSender)
> -    eventSender.keyDown(' ');
> -var pickerWindow = document.getElementById('mock-page-popup').contentWindow;
> -pickerWindow.onresize = function() {
> -    testRunner.notifyDone();
> +function test() {
> +    finishJSTest();
>  }

ditto.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html:44
> +<script>
> +openPicker(document.getElementById('date'), finishTest);
>  
>  function finishTest() {
> -    popupWindow.removeEventListener('resize', finishTest);
> -    setTimeout(function() { testRunner.notifyDone(); }, 0);
> +    finishJSTest();
>  }

ditto.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html:48
> +openPicker(document.getElementById('date'), finishTest);
> +
>  function finishTest() {
> -    popupWindow.removeEventListener('resize', finishTest);
>      popupWindow.focus();
>      eventSender.keyDown('downArrow');
> -    setTimeout(function() {testRunner.notifyDone();}, 0);
> +    finishJSTest();
>  }

ditto.

[Keishi Hattori]

Created attachment 169828 [details]
Patch

[Kent Tamura]

Comment on attachment 169828 [details]
Patch

looks good

[WebKit Review Bot]

Comment on attachment 169828 [details]
Patch

Clearing flags on attachment: 169828

Committed r132028: <http://trac.webkit.org/changeset/132028>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.