Bug 99628

Summary: [BlackBerry] Remove unnecessary assertion in WebPage::executeJavaScript.
Product: WebKit Reporter: Lyon Chen <liachen>
Component: WebKit BlackBerryAssignee: Lyon Chen <liachen>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch for 99628. rwlbuis: review-

Lyon Chen
Reported 2012-10-17 12:39:55 PDT
Right now BlackBerry::Platform::String::isUtf8() mainly reflects whether the string is constructed from a utf8 string. It doesn't reflect whether a string is utf8 or not if it is constructed otherwise. And it is now assumed that all string in BlackBerry::Platform::String is either ASCII or UTF8 encoded. The assertion in WebPage::executeJavaScript() and WebPage::executeJavaScriptInIsolatedWorld() is unnecessary and should be removed.
Attachments
patch for 99628. (2.22 KB, patch)
2012-10-17 12:43 PDT, Lyon Chen 		rwlbuis: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lyon Chen
Comment 1 2012-10-17 12:43:53 PDT
Created attachment 169236 [details] patch for 99628.
Rob Buis
Comment 2 2012-10-25 07:32:23 PDT
Comment on attachment 169236 [details] patch for 99628. To me it looks like when isUTF8() is true, it really means the internal string is utf8 encoded, no matter what string it was constructed from. If it is false it might still be utf8. This assert simply verifies that the String is guarenteed to be utf8 encoded, which seems fine. So unless we start seeing problems here, I will r- for now.
Note You need to log in before you can comment on or make changes to this bug.