Summary: | Unable to rebaseline windows tests | ||
---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> |
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, ojan |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Dana Jansens
2012-10-17 12:15:34 PDT
looking These five tests are only failing in Debug mode, and we don't check in baselines that only affect Debug if we also have Release bots in that config (since then Release would start to fail). In this situation you need to suppress the failures and file a bug for someone to figure out why we're getting different output in Debug and Release. whoops, shouldn't have wontfix'ed this until I was sure my explanation made sense to you (I didn't actually look at the failures in detail). Does it change anything that the release bot is still failing these tests too? Tho garden-o-matic doesn't seem aware. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/143/steps/webkit_tests Yes, that would definitely change things :). That sounds like a bug in g-o-m. Looking again. Okay, the problem is that the Win7 Release results are not being uploaded to the correct folder, and so we're not finding them (so I think we think the tests are passing on Win7 Release). Unfortunately, garden-o-matic isn't reporting an error in this case. Separately, it looks like the data in Tools/Scripts/webkitpy/layout_tests/port/builders.py is wrong; I'm not sure what the implications of that is except that bad things would probably happen between win7 and xp baselines. Working on it ... Okay, you should be getting the windows baselines now. Let me know if you still have issues. I'll file other bugs for the lack-of-error and the builders.py issues. Yup! Thanks :) |