Bug 99615

Summary: Add diagnostic logging to track per-page media engine usage.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, japhet, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jer Noble
Reported 2012-10-17 10:50:27 PDT
Add diagnostic logging to track per-page media engine usage.
Attachments
Patch (8.31 KB, patch)
2012-10-17 11:04 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (8.30 KB, patch)
2012-10-17 13:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-10-17 10:59:31 PDT
<rdar://problem/12476473>
Jer Noble
Comment 2 2012-10-17 11:04:10 PDT
Created attachment 169218 [details] Patch
Jer Noble
Comment 3 2012-10-17 13:59:22 PDT
Created attachment 169254 [details] Patch Filled in ChangeLog boilerplate; changed parameter names in new Page methods.
Eric Carlson
Comment 4 2012-10-17 14:03:45 PDT
Comment on attachment 169254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169254&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1539 > + page->sawMediaEngine(mediaEngine); Do you want to call this when "mediaEngine" is empty?
Jer Noble
Comment 5 2012-10-18 10:57:44 PDT
(In reply to comment #4) > (From update of attachment 169254 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169254&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:1539 > > + page->sawMediaEngine(mediaEngine); > > Do you want to call this when "mediaEngine" is empty? There's an early return above when loading fails (and thus mediaEngine is empty). Thanks!
WebKit Review Bot
Comment 6 2012-10-18 11:13:03 PDT
Comment on attachment 169254 [details] Patch Clearing flags on attachment: 169254 Committed r131779: <http://trac.webkit.org/changeset/131779>
WebKit Review Bot
Comment 7 2012-10-18 11:13:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.