Bug 99609

Summary: r130956 uses legacy API and creates bogus JSGlobalDatas in all layout tests
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: mhahnenberg, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93958    
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2012-10-17 10:24:07 PDT
While investigating another GC bug, I noticed that some tests that were calling HeapStatistics::usedJSHeap, which in turn calls into JSGlobalData::sharedInstance. sharedInstance() is a legacy API that creates a new, static JSGlobalData instance completely unrelated to the JSGlobalData that was used during the layout test. This is almost certainly not the behavior that was intended. You will need to get ahold of the JSGlobalData in a different fashion. JSDOMWindowBase::commonJSGlobalData() may be more of what you're looking for.
Attachments
Patch (3.39 KB, patch)
2012-10-17 22:01 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-10-17 10:44:59 PDT
Thanks Mark, I'm going to fix this.
Zoltan Horvath
Comment 2 2012-10-17 22:01:22 PDT
Created attachment 169338 [details] Patch
Zoltan Horvath
Comment 3 2012-10-17 22:03:25 PDT
I don't want to let the code in. I will come up with the proper solution soon separately.
WebKit Review Bot
Comment 4 2012-10-17 23:00:03 PDT
Comment on attachment 169338 [details] Patch Clearing flags on attachment: 169338 Committed r131707: <http://trac.webkit.org/changeset/131707>
WebKit Review Bot
Comment 5 2012-10-17 23:00:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.