Bug 99585

Summary: [BlackBerry] Let WebKit manage the SelectionOverlay
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Arvid Nilsson
Reported 2012-10-17 04:42:31 PDT
Currently, the SelectionOverlay is exposed to clients of the BlackBerry::WebKit API. However, all the information and notifications necessary to manage the SelectionOverlay are available within WebKit, so the client does not have to shoulder this responsibility, WebKit could do it for them. PR 225789
Attachments
Patch (10.55 KB, patch)
2012-10-17 10:45 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2012-10-17 10:45:34 PDT
Created attachment 169214 [details] Patch
Arvid Nilsson
Comment 2 2012-10-18 09:10:10 PDT
Reviewed internally by Mike Fenton.
Rob Buis
Comment 3 2012-10-23 07:04:44 PDT
Comment on attachment 169214 [details] Patch LGTM.
Arvid Nilsson
Comment 4 2012-10-23 07:47:16 PDT
Comment on attachment 169214 [details] Patch Thanks Rob =)
WebKit Review Bot
Comment 5 2012-10-23 07:52:31 PDT
Comment on attachment 169214 [details] Patch Clearing flags on attachment: 169214 Committed r132224: <http://trac.webkit.org/changeset/132224>
WebKit Review Bot
Comment 6 2012-10-23 07:52:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.