Bug 99582

Summary: Bind isolatedWorldSecurityOrigin to world
Product: WebKit Reporter: Dan Carney <dcarney>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97398    
Attachments:
Description Flags
Patch
none
Patch none

Description Dan Carney 2012-10-17 04:26:27 PDT
Bind isolatedWorldSecurityOrigin to world
Comment 1 Dan Carney 2012-10-17 04:36:34 PDT
Created attachment 169153 [details]
Patch
Comment 2 Adam Barth 2012-10-17 09:01:18 PDT
Comment on attachment 169153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169153&action=review

This has the effect of making the security origin for isolated worlds global rather than per-frame.  That seems like what the embedder would want.

I presume the next step is to store this information in DOMWrapperWorld directly rather than using a hash map.

> LayoutTests/http/tests/security/isolatedWorld/cross-origin-xhr.html:51
> +        				testRunner.setIsolatedWorldSecurityOrigin(1, null);
> +				        testRunner.setIsolatedWorldSecurityOrigin(2, null);

Looks like you've got a bad indent here.  Please use spaces rather than tabs.
Comment 3 Dan Carney 2012-10-17 09:36:11 PDT
Comment on attachment 169153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169153&action=review

>> LayoutTests/http/tests/security/isolatedWorld/cross-origin-xhr.html:51
>> +				        testRunner.setIsolatedWorldSecurityOrigin(2, null);
> 
> Looks like you've got a bad indent here.  Please use spaces rather than tabs.

done.
Comment 4 Dan Carney 2012-10-17 09:37:52 PDT
(In reply to comment #2)
> (From update of attachment 169153 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169153&action=review
> 
> This has the effect of making the security origin for isolated worlds global rather than per-frame.  That seems like what the embedder would want.
> 
> I presume the next step is to store this information in DOMWrapperWorld directly rather than using a hash map.

Unfortunately, there is a mismatch between the lifetimes of the object, so this may have to stay as a hashmap for now.
Comment 5 Dan Carney 2012-10-17 09:38:19 PDT
Created attachment 169197 [details]
Patch
Comment 6 WebKit Review Bot 2012-10-17 12:34:22 PDT
Comment on attachment 169197 [details]
Patch

Clearing flags on attachment: 169197

Committed r131629: <http://trac.webkit.org/changeset/131629>
Comment 7 WebKit Review Bot 2012-10-17 12:34:25 PDT
All reviewed patches have been landed.  Closing bug.