Bug 99575

Summary: [EFL][WK2] Remove '_' prefix from private API structure names
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
gyuyoung.kim: review+, webkit.review.bot: commit-queue-
to be landed none

Mikhail Pozdnyakov
Reported 2012-10-17 03:01:03 PDT
Underscore symbols need to be removed from private API structure names, it will let us to remove 'typedef _name name;' from all the private headers and will make code look better.
Attachments
patch (60.74 KB, patch)
2012-10-17 05:02 PDT, Mikhail Pozdnyakov 		gyuyoung.kim: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
to be landed (60.65 KB, patch)
2012-10-18 00:23 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-10-17 05:02:55 PDT
Created attachment 169160 [details] patch
WebKit Review Bot
Comment 2 2012-10-17 21:13:04 PDT
Comment on attachment 169160 [details] patch Rejecting attachment 169160 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Hunk #2 FAILED at 148. Hunk #3 succeeded at 167 (offset -1 lines). Hunk #4 succeeded at 503 (offset -4 lines). 1 out of 4 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp.rej patching file Source/WebKit2/UIProcess/API/efl/ewk_view.h patching file Source/WebKit2/UIProcess/API/efl/ewk_view_private.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gyuyoung K..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14397863
Mikhail Pozdnyakov
Comment 3 2012-10-18 00:23:59 PDT
Created attachment 169359 [details] to be landed
WebKit Review Bot
Comment 4 2012-10-18 01:01:16 PDT
Comment on attachment 169359 [details] to be landed Clearing flags on attachment: 169359 Committed r131712: <http://trac.webkit.org/changeset/131712>
WebKit Review Bot
Comment 5 2012-10-18 01:01:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.