Bug 99572

Summary: REGRESSION(r131421): Text baseline becomes incorrect after re-layout of input[type=time]
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, haraken, macpherson, menard, morrita, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Screenshot
none
Patch none

Description Kent Tamura 2012-10-17 02:42:40 PDT 
e.g.

<span style="font-size: 64px;">Foo</span>
<input type="time" id="time1">
<input type="time" id="time2">

1. Render this
2. Setting "23:59" to time1.value
3. The time1 field jumps up  (See attachment)
Comment 1 Kent Tamura 2012-10-17 02:44:21 PDT 
Created attachment 169141 [details]
Screenshot
Comment 2 Kent Tamura 2012-10-17 02:56:35 PDT 
Created attachment 169143 [details]
Patch
Comment 3 Kentaro Hara 2012-10-17 03:24:18 PDT 
Comment on attachment 169143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169143&action=review

Looks OK

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html:12
> +container.remove();

Does this work?
Comment 4 Kent Tamura 2012-10-17 03:27:12 PDT 
Comment on attachment 169143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169143&action=review

>> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html:12
>> +container.remove();
> 
> Does this work?

Yes.  WebKit has Element::remove().
Comment 5 WebKit Review Bot 2012-10-17 03:40:14 PDT 
Comment on attachment 169143 [details]
Patch

Clearing flags on attachment: 169143

Committed r131581: <http://trac.webkit.org/changeset/131581>
Comment 6 WebKit Review Bot 2012-10-17 03:40:18 PDT 
All reviewed patches have been landed.  Closing bug.