Bug 99569

Summary: Web Inspector: delete watch expression button overlaps with the expression value
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot
none
Patch
none
Patch none

Yury Semikhatsky
Reported 2012-10-17 02:07:45 PDT
The minus button shouldn't overlap with the expression text/value.
Attachments
Screenshot (56.55 KB, image/png)
2012-10-17 02:13 PDT, Yury Semikhatsky 		no flags
Details
Patch (1.45 KB, patch)
2012-10-17 02:14 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2012-10-17 03:01 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-10-17 02:13:56 PDT
Created attachment 169133 [details] Screenshot
Yury Semikhatsky
Comment 2 2012-10-17 02:14:14 PDT
Created attachment 169134 [details] Patch
Vsevolod Vlasov
Comment 3 2012-10-17 02:32:38 PDT
Comment on attachment 169134 [details] Patch Still doesn't work :)
Yury Semikhatsky
Comment 4 2012-10-17 03:01:18 PDT
Created attachment 169144 [details] Patch
Vsevolod Vlasov
Comment 5 2012-10-17 03:15:27 PDT
Comment on attachment 169144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169144&action=review > Source/WebCore/inspector/front-end/inspector.css:1594 > +.properties-tree.watch-expressions > li > .value { We should probably remove this properties completely instead of overriding them. I don't think they are really needed.
Yury Semikhatsky
Comment 6 2012-10-17 04:44:46 PDT
Comment on attachment 169144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169144&action=review >> Source/WebCore/inspector/front-end/inspector.css:1594 >> +.properties-tree.watch-expressions > li > .value { > > We should probably remove this properties completely instead of overriding them. > I don't think they are really needed. This would break formatting of console messages like console.log("%o is an object", {});
WebKit Review Bot
Comment 7 2012-10-17 04:50:29 PDT
Comment on attachment 169144 [details] Patch Clearing flags on attachment: 169144 Committed r131587: <http://trac.webkit.org/changeset/131587>
WebKit Review Bot
Comment 8 2012-10-17 04:50:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.