| Summary: | GraphicsLayer visible rect computation needs to use the current animating transform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, danakj, dino, enne, epenner, eric, simon.fraser, thorton, vollick, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2012-10-16 18:04:58 PDT
Created attachment 169067 [details]
Patch
Comment on attachment 169067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169067&action=review > Source/WebCore/platform/graphics/GraphicsLayerClient.h:75 > + virtual void currentTransform(const GraphicsLayer*, TransformationMatrix&) const { } It's a bit strange that this method is called currentTransform like the existing method on RenderLayer, but modifies its parameter rather than providing a return value. > Source/WebCore/rendering/RenderLayer.h:598 > - TransformationMatrix currentTransform() const; > + TransformationMatrix currentTransform(RenderStyle::ApplyTransformOrigin = RenderStyle::IncludeTransformOrigin) const; This is the existing one (in another class) > Source/WebCore/rendering/RenderLayerBacking.h:151 > + virtual void currentTransform(const GraphicsLayer*, TransformationMatrix&) const; This is the new one. > LayoutTests/compositing/visible-rect/animated.html:26 > + @-webkit-keyframes move { > + from { -webkit-transform: translateX(-100px); } > + to { -webkit-transform: translateX(300px); } > + } I'm not sure how this test is exercising the new code. You don't have anything here that setting transform origin. |