Bug 99518 – Create a GraphicsLayerUpdater class that will do periodic layer flushes for layer trees containing tile caches

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Create a GraphicsLayerUpdater class that will do periodic layer flushes for layer trees containing tile caches

[Simon Fraser (smfr)]

Created attachment 169057 [details]
Patch

[Dean Jackson]

Comment on attachment 169057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169057&action=review

Shame we can't test any of this.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:6360
> +		FD315FFE12B0267600C1A359 /* ChannelMergerNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD315FB412B0267500C1A359 /* ChannelMergerNode.cpp */; };

I'll just assume all these unrelated changes are ok - did you sort entries or something?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:41
> +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
> +    DisplayRefreshMonitorManager::sharedManager()->registerClient(this);
> +    DisplayRefreshMonitorManager::sharedManager()->windowScreenDidChange(displayID, this);
> +    DisplayRefreshMonitorManager::sharedManager()->scheduleAnimation(this);
> +#endif

So I guess other ports will have to implement their own GLUpdater machinery?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:47
> +GraphicsLayerUpdater::~GraphicsLayerUpdater()
> +{
> +    // ~DisplayRefreshMonitorClient unregisters us as a client.
> +}

Is there ever a case where the GLU can go away before the DRMC does?

> Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:35
> +class GraphicsLayer;

Not sure you need this.

[Build Bot]

Comment on attachment 169057 [details]
Patch

Attachment 169057 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14397334

[WebKit Review Bot]

Comment on attachment 169057 [details]
Patch

Attachment 169057 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14384358

[Simon Fraser (smfr)]

Created attachment 169061 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 169061 [details]
Patch

Bring dino review forward. Try to fix the EWSes.

[Gyuyoung Kim]

Comment on attachment 169061 [details]
Patch

Attachment 169061 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14384385

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/131680

[Dean Jackson]

James said this broke clang builds. Fix is in r131692