Bug 99512

Summary: Remove --shark* support from sunspider/run-sunspider now that Shark is dead
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99514    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2012-10-16 15:01:41 PDT
Remove --shark* support from sunspider/run-sunspider now that Shark is dead Unless there are objections?
Attachments
Patch (8.65 KB, patch)
2012-10-16 15:18 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (8.65 KB, patch)
2012-10-16 15:25 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-10-16 15:18:34 PDT
Created attachment 169040 [details] Patch
WebKit Review Bot
Comment 2 2012-10-16 15:23:54 PDT
Attachment 169040 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/SunSpider/ChangeLog', u'P..." exit_code: 1 PerformanceTests/SunSpider/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2012-10-16 15:25:59 PDT
Created attachment 169041 [details] Patch
Maciej Stachowiak
Comment 4 2012-10-16 23:54:46 PDT
JSC folks, would you still conceivably use this ever?
Eric Seidel (no email)
Comment 5 2012-10-31 01:25:43 PDT
Is it even possible to get shark from anywhere?
Darin Adler
Comment 6 2013-01-16 11:18:47 PST
Comment on attachment 169041 [details] Patch I’m not 100 sure that this is useless. Some people may be using this on older versions of OS X and tool suites. But if so, they can squawk and bring the code back.
WebKit Review Bot
Comment 7 2013-01-16 11:27:05 PST
Comment on attachment 169041 [details] Patch Clearing flags on attachment: 169041 Committed r139902: <http://trac.webkit.org/changeset/139902>
WebKit Review Bot
Comment 8 2013-01-16 11:27:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.