| Summary: | Remove --shark* support from sunspider/run-sunspider now that Shark is dead | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | Tools / Tests | Assignee: | Eric Seidel (no email) <eric> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, ggaren, mjs, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 99514 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2012-10-16 15:01:41 PDT
Created attachment 169040 [details]
Patch
Attachment 169040 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'PerformanceTests/SunSpider/ChangeLog', u'P..." exit_code: 1
PerformanceTests/SunSpider/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 169041 [details]
Patch
JSC folks, would you still conceivably use this ever? Is it even possible to get shark from anywhere? Comment on attachment 169041 [details]
Patch
I’m not 100 sure that this is useless. Some people may be using this on older versions of OS X and tool suites. But if so, they can squawk and bring the code back.
Comment on attachment 169041 [details] Patch Clearing flags on attachment: 169041 Committed r139902: <http://trac.webkit.org/changeset/139902> All reviewed patches have been landed. Closing bug. |