Bug 99487

Summary: Update indentation in *ResourceLoader headers to match modern WebKit style
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 bdakin: review+

Brady Eidson
Reported 2012-10-16 12:17:33 PDT
Update indentation in *ResourceLoader headers to match modern WebKit style
Attachments
Patch v1 (24.12 KB, patch)
2012-10-16 12:19 PDT, Brady Eidson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-16 12:19:06 PDT
Created attachment 168995 [details] Patch v1
WebKit Review Bot
Comment 2 2012-10-16 12:23:44 PDT
Attachment 168995 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/loader/ResourceLoader.h:153: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2012-10-16 13:14:41 PDT
(In reply to comment #2) > Attachment 168995 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/loader/ResourceLoader.h:153: One space before end of line comments [whitespace/comments] [5] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Fixed that, won't re-upload the patch.
Brady Eidson
Comment 4 2012-10-16 13:22:30 PDT
http://trac.webkit.org/changeset/131492
Brady Eidson
Comment 5 2012-10-16 13:22:57 PDT
(In reply to comment #3) > (In reply to comment #2) > > Attachment 168995 [details] [details] did not pass style-queue: > > > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebCore/loader/ResourceLoader.h:153: One space before end of line comments [whitespace/comments] [5] > > Total errors found: 1 in 4 files > > > > > > If any of these errors are false positives, please file a bug against check-webkit-style. > > Fixed that, won't re-upload the patch. Didn't actually fix that. There's precedent for keeping groups of comments aligned like that.
Note You need to log in before you can comment on or make changes to this bug.