Summary: | Implement the Selector argument to RTCPeerConnection.getStats | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Harald Alvestrand <hta> | ||||||||||
Component: | WebKit Misc. | Assignee: | Harald Alvestrand <hta> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, cabanier, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, tkent+wkapi, tommyw, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 56459 | ||||||||||||
Attachments: |
|
Description
Harald Alvestrand
2012-10-16 05:44:15 PDT
Created attachment 168937 [details]
Patch
Comment on attachment 168937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168937&action=review > Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:47 > + , m_stream(selector?selector->streamDescriptor():0) Space around operators > Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:66 > +PassRefPtr<MediaStreamDescriptor> RTCStatsRequestImpl::stream() Only return a PassRefPtr is ownership is transfered, otherwise use raw pointers: return m_stream.get() http://www.webkit.org/coding/RefPtr.html > Source/WebCore/platform/mediastream/RTCStatsRequest.h:52 > + virtual PassRefPtr<MediaStreamDescriptor> stream() = 0; See the comment above. Created attachment 168942 [details]
Patch
Created attachment 168946 [details]
Patch
Comment on attachment 168937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168937&action=review >> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:47 >> + , m_stream(selector?selector->streamDescriptor():0) > > Space around operators Done. >> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:66 >> +PassRefPtr<MediaStreamDescriptor> RTCStatsRequestImpl::stream() > > Only return a PassRefPtr is ownership is transfered, otherwise use raw pointers: return m_stream.get() > http://www.webkit.org/coding/RefPtr.html Done. >> Source/WebCore/platform/mediastream/RTCStatsRequest.h:52 >> + virtual PassRefPtr<MediaStreamDescriptor> stream() = 0; > > See the comment above. Done. Comment on attachment 168946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review > Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:68 > Nit: extra empty line > Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:84 > + Nit: extra empty line Comment on attachment 168946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review This patch looks good. Tommy and I have some very minor style issues that we should clear up before landing. > Source/Platform/chromium/public/WebRTCStatsRequest.h:89 > + WEBKIT_EXPORT bool hasSelector() const; > + > + WEBKIT_EXPORT const WebMediaStreamDescriptor stream() const; > + > + WEBKIT_EXPORT const WebMediaStreamComponent component() const; I might have added some comments explaining the relationship between these functions. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Created attachment 169140 [details]
Patch for landing
Comment on attachment 168946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review >> Source/Platform/chromium/public/WebRTCStatsRequest.h:89 >> + WEBKIT_EXPORT const WebMediaStreamComponent component() const; > > I might have added some comments explaining the relationship between these functions. Done. > Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:68 > Fixed. >> Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:84 >> + > > Nit: extra empty line Fixed. Comment on attachment 169140 [details] Patch for landing Rejecting attachment 169140 [details] from commit-queue. hta@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 169140 [details] Patch for landing Clearing flags on attachment: 169140 Committed r131584: <http://trac.webkit.org/changeset/131584> |