Bug 99455

Summary: [EFL][WK2] Inherit Ewk_Download_Job, Ewk_Back_Forward_List_Item, Ewk_Url_Response, Ewk_Navigation_Policy_Decision from RefCounted
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99321    
Attachments:
Description Flags
patch
kenneth: review+
patch v2 none

Mikhail Pozdnyakov
Reported 2012-10-16 05:04:03 PDT
Sub bug for bug#99321
Attachments
patch (28.50 KB, patch)
2012-10-16 05:09 PDT, Mikhail Pozdnyakov
kenneth: review+
patch v2 (28.50 KB, patch)
2012-10-16 06:32 PDT, Mikhail Pozdnyakov
no flags
Mikhail Pozdnyakov
Comment 1 2012-10-16 05:09:58 PDT
Kenneth Rohde Christiansen
Comment 2 2012-10-16 06:05:17 PDT
Comment on attachment 168923 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=168923&action=review > Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:NaN > static inline Ewk_Back_Forward_List_Item* addItemToWrapperCache(const Ewk_Back_F it's internal, maybe we should return the PassRefPtr? > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:51 > + _Ewk_Navigation_Policy_Decision(WKFramePolicyListenerRef _listener, Ewk_Navigation_Type _navigationType, Event_Mouse_Button _mouseButton, Event_Modifier_Keys _modifiers, PassRefPtr<Ewk_Url_Request> _request, const char* _frameName) C++ doesnt require you to add _ here : listener(listener) should work
Mikhail Pozdnyakov
Comment 3 2012-10-16 06:29:28 PDT
(In reply to comment #2) > (From update of attachment 168923 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168923&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:NaN > > static inline Ewk_Back_Forward_List_Item* addItemToWrapperCache(const Ewk_Back_F > > it's internal, maybe we should return the PassRefPtr? To my mind it would not be convenient as we have several functions like following: Ewk_Back_Forward_List_Item* ewk_back_forward_list_current_item_get(const Ewk_Back_Forward_List* list) { EWK_BACK_FORWARD_LIST_WK_GET_OR_RETURN(list, wkList, 0); return addItemToWrapperCache(list, WKBackForwardListGetCurrentItem(wkList)); } if PassRefPtr was returned it would be return RefPtr<Ewk_Back_Forward_List_Item>(addItemToWrapperCache(list, WKBackForwardListGetCurrentItem(wkList))).get(); that looks worse IMHO > > > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:51 > > + _Ewk_Navigation_Policy_Decision(WKFramePolicyListenerRef _listener, Ewk_Navigation_Type _navigationType, Event_Mouse_Button _mouseButton, Event_Modifier_Keys _modifiers, PassRefPtr<Ewk_Url_Request> _request, const char* _frameName) > > C++ doesnt require you to add _ here > > : listener(listener) should work sure
Mikhail Pozdnyakov
Comment 4 2012-10-16 06:32:45 PDT
Created attachment 168936 [details] patch v2 Took Kenneth comment into consideration.
WebKit Review Bot
Comment 5 2012-10-16 09:08:03 PDT
Comment on attachment 168936 [details] patch v2 Clearing flags on attachment: 168936 Committed r131460: <http://trac.webkit.org/changeset/131460>
WebKit Review Bot
Comment 6 2012-10-16 09:08:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.