Bug 99449

Summary:

WebPageProxy::canShowMIMEType() should return false for plugins when they are disabled

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, beidson, cabanier, gustavo, mrobinson, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	andersca: review-
Updated patch	andersca: review+

Carlos Garcia Campos

Reported 2012-10-16 04:03:51 PDT

It currently returns true, but if the web view tries to handle the plugin it ends up rendering garbage.

Attachments
Patch (4.07 KB, patch) 2012-10-16 04:06 PDT, Carlos Garcia Campos	andersca: review-	Details Formatted Diff Diff
Updated patch (3.94 KB, patch) 2012-10-18 00:07 PDT, Carlos Garcia Campos	andersca: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2012-10-16 04:06:38 PDT

Created attachment 168915 [details] Patch

Rik Cabanier

Comment 2 2012-10-16 09:21:01 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Alexey Proskuryakov

Comment 3 2012-10-16 10:20:52 PDT

Could you please post a URL of a web page that's affected? Since this changes cross-platform code, I'd like to see this issue in practice on Mac. If not handled, what will happen with plug-in resources? Will they be downloaded?

Xan Lopez

Comment 4 2012-10-16 10:31:52 PDT

(In reply to comment #3) > Could you please post a URL of a web page that's affected? Since this changes cross-platform code, I'd like to see this issue in practice on Mac. Not sure what page was Carlos using to test this. I have been using http://www.ikea.com/fr/fr/, which contains a SWF resource. > > If not handled, what will happen with plug-in resources? Will they be downloaded? That is mostly up to the port and/or the embedder. In WebKitGTK+/Epiphany we'll download the resource if it's the main resource (so that clicking on link that points to a PDF file will download it), but ignore anything else (so that a <object> tag pointing to a SWF file will be ignored if Flash is not supported).

Alexey Proskuryakov

Comment 5 2012-10-16 10:39:15 PDT

There is indeed a garbage subframe in Safari on this IKEA page. For Apple employees: see also <rdar://problem/11650197>.

Carlos Garcia Campos

Comment 6 2012-10-16 23:52:26 PDT

(In reply to comment #5) > There is indeed a garbage subframe in Safari on this IKEA page. Yes, this is exactly what happens in MiniBrowser if plugins are disabled. > For Apple employees: see also <rdar://problem/11650197>.

Anders Carlsson

Comment 7 2012-10-17 10:56:31 PDT

Comment on attachment 168915 [details] Patch I don't think the shouldBlockPlugin check is correct here. We should try (and fail) to load the plug-in when it's blocked. Please remove that check.

Carlos Garcia Campos

Comment 8 2012-10-18 00:07:00 PDT

Created attachment 169356 [details] Updated patch

Anders Carlsson

Comment 9 2012-10-18 11:55:27 PDT

Comment on attachment 169356 [details] Updated patch r=me

Carlos Garcia Campos

Comment 10 2012-10-19 00:19:14 PDT

Committed r131867: <http://trac.webkit.org/changeset/131867>

Note You need to log in before you can comment on or make changes to this bug.