Bug 99410

Summary: [Page Visibility API] View-less documents should report as hidden
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: James Simonsen <simonjam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, shishir, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60576    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description James Simonsen 2012-10-15 20:18:48 PDT
[Page Visibility API] View-less documents should report as hidden
Comment 1 James Simonsen 2012-10-15 20:19:10 PDT
Created attachment 168842 [details]
Patch
Comment 2 James Simonsen 2012-10-15 20:20:25 PDT
Per the spec:

"If the defaultView of the Document is null, on getting, the hidden attribute MUST return true."
Comment 3 Build Bot 2012-10-15 20:46:29 PDT
Comment on attachment 168842 [details]
Patch

Attachment 168842 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14385013

New failing tests:
fast/events/page-visibility-null-view.html
Comment 4 WebKit Review Bot 2012-10-15 23:19:28 PDT
Comment on attachment 168842 [details]
Patch

Attachment 168842 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14396012

New failing tests:
fast/events/page-visibility-null-view.html
Comment 5 James Simonsen 2012-10-16 11:18:53 PDT
Created attachment 168985 [details]
Patch
Comment 6 Tony Gentilcore 2012-10-16 11:45:11 PDT
Comment on attachment 168985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168985&action=review

Everything else looks good.

> Source/WebCore/dom/Document.cpp:1629
>      // specified by the embedder.

This comment needs to be updated. Perhaps point to the spec.
Comment 7 James Simonsen 2012-10-16 14:24:48 PDT
Created attachment 169026 [details]
Patch
Comment 8 James Simonsen 2012-10-16 14:27:10 PDT
(In reply to comment #6)
> (From update of attachment 168985 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168985&action=review
> 
> Everything else looks good.
> 
> > Source/WebCore/dom/Document.cpp:1629
> >      // specified by the embedder.
> 
> This comment needs to be updated. Perhaps point to the spec.

Done.
Comment 9 Build Bot 2012-10-16 15:18:48 PDT
Comment on attachment 169026 [details]
Patch

Attachment 169026 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14386313

New failing tests:
fast/events/page-visibility-null-view.html
Comment 10 James Simonsen 2012-10-16 16:25:58 PDT
Created attachment 169050 [details]
Patch for landing
Comment 11 WebKit Review Bot 2012-10-16 17:04:57 PDT
Comment on attachment 169050 [details]
Patch for landing

Clearing flags on attachment: 169050

Committed r131530: <http://trac.webkit.org/changeset/131530>
Comment 12 WebKit Review Bot 2012-10-16 17:05:01 PDT
All reviewed patches have been landed.  Closing bug.