Bug 99402

Summary:

Add 8 bit path to Document::isValidName() for the non ASCII case

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

WebCore Misc.

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

shinyak, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

99420

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Michael Saboff

Reported 2012-10-15 18:12:40 PDT

If a name passed into isValidName() fails the isValidNameASCII() check and it is an 8 bit string, it is up-converted to a 16 bit string.

Attachments
Patch (2.25 KB, patch) 2012-10-15 18:34 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2012-10-15 18:34:01 PDT

Created attachment 168833 [details] Patch

Darin Adler

Comment 2 2012-10-15 20:00:15 PDT

Comment on attachment 168833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168833&action=review OK. Annoying to have to repeat the code like this; would be nicer if there was a simple way to use a template for this. > Source/WebCore/ChangeLog:3 > + Add 8 bit patch to Document::isValidName() for the non ASCII case patch -> path

WebKit Review Bot

Comment 3 2012-10-15 20:29:20 PDT

Comment on attachment 168833 [details] Patch Clearing flags on attachment: 168833 Committed r131403: <http://trac.webkit.org/changeset/131403>

WebKit Review Bot

Comment 4 2012-10-15 20:29:23 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2012-10-15 23:33:06 PDT

Re-opened since this is blocked by bug 99420

Alexey Proskuryakov

Comment 6 2012-10-16 10:26:39 PDT

Has the patch been rolled back in?

Michael Saboff

Comment 7 2012-10-16 16:10:17 PDT

(In reply to comment #5) > Re-opened since this is blocked by bug 99420 Change set r131403 appears to be rolled back in with change set r131425 <http://trac.webkit.org/changeset/131425>. Can we close this defect?

Shinya Kawanaka

Comment 8 2012-10-16 19:47:41 PDT

(In reply to comment #7) > (In reply to comment #5) > > Re-opened since this is blocked by bug 99420 > > Change set r131403 appears to be rolled back in with change set r131425 <http://trac.webkit.org/changeset/131425>. > > Can we close this defect? Ohya. Yes. We can close this. Sorry for bothering you.

Note You need to log in before you can comment on or make changes to this bug.