Summary: | Fold setCellLogicalWidths logic into RenderTableSection layout | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||
Component: | Tables | Assignee: | Julien Chaffraix <jchaffraix> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, eric, hyatt, inferno, robert, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Julien Chaffraix
2012-10-15 16:17:50 PDT
Created attachment 168809 [details]
Proposed change v1.
Comment on attachment 168809 [details]
Proposed change v1.
The logic looks fine. I wonder what (if any) perf benefit this has.
(In reply to comment #2) > (From update of attachment 168809 [details]) > The logic looks fine. I wonder what (if any) perf benefit this has. Following our discussion, I tried http://www.robohornet.org/#e=resizecol: Before: 500x10 510.43ms ± 0.69% 500x50 884.67s ± 1.48% After: 500x10 509.21ms ± 0.75% 500x50 878.89ms ± 1.40% It's really a wash, which confirmed some of my rough testing on http://dglazkov.github.com/performance-tests/redraw.html. Thanks. Comment on attachment 168809 [details] Proposed change v1. Clearing flags on attachment: 168809 Committed r131465: <http://trac.webkit.org/changeset/131465> All reviewed patches have been landed. Closing bug. |