Bug 99298

Summary: Add a test to check that strings are localized in the suggestion picker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED INVALID    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99423    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-10-15 01:13:51 PDT
Add a test to check that strings are localized in the suggestion picker
Attachments
Patch (15.82 KB, patch)
2012-10-15 01:53 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2012-10-15 21:24 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-10-15 01:53:56 PDT
Created attachment 168651 [details] Patch
Keishi Hattori
Comment 2 2012-10-15 01:58:43 PDT
chromium side patch https://codereview.chromium.org/11141021
Kent Tamura
Comment 3 2012-10-15 02:00:41 PDT
Comment on attachment 168651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168651&action=review > Source/WebCore/ChangeLog:8 > + This adds a stringLocalizationTestModeEnabled runtime flag. When it is I don't think we need the flag. It's ok that TestWebKitPlatformSupport always provide strings for testing.
Keishi Hattori
Comment 4 2012-10-15 21:24:23 PDT
Created attachment 168846 [details] Patch
Kent Tamura
Comment 5 2012-10-15 21:37:02 PDT
Comment on attachment 168846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168846&action=review > LayoutTests/ChangeLog:11 > + * platform/chromium/fast/forms/date/date-suggestion-picker-localization-expected.txt: Added. > + * platform/chromium/fast/forms/date/date-suggestion-picker-localization.html: Added. Don't platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html cover this?
Keishi Hattori
Comment 6 2012-10-15 23:54:00 PDT
I guess it does.
Note You need to log in before you can comment on or make changes to this bug.