Move framework and library linking into WebKit.xcconfig

• Component: Platform
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Created attachment 168611 [details]
Patch

<http://webkit.org/b/00000>

Reviewed by NOBODY (OOPS!).

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Remove frameworks and
libraries from Xcode project file.

Source/WebKit/mac:

* Configurations/WebKit.xcconfig: Move frameworks and libraries
link flags to OTHER_LDFLAGS so that they work for iOS and OS X.
---
 4 files changed, 24 insertions(+), 23 deletions(-)

[WebKit Review Bot]

Attachment 168611 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/..." exit_code: 1
Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Rowe (bdash)]

Comment on attachment 168611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168611&action=review

> Source/WebKit/mac/Configurations/WebKit.xcconfig:70
> +OTHER_LDFLAGS_BASE = -licucore -framework JavaScriptCore -framework QuartzCore -framework WebCore;

Is this really better than just leaving the shared ones in the usual place?

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 168611 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168611&action=review
> 
> > Source/WebKit/mac/Configurations/WebKit.xcconfig:70
> > +OTHER_LDFLAGS_BASE = -licucore -framework JavaScriptCore -framework QuartzCore -framework WebCore;
> 
> Is this really better than just leaving the shared ones in the usual place?

I figured it was simpler to have everything specified in one location rather than having to rubberneck between the UI (Xcode project file) and WebKit.xcconfig.  It would make the rules simpler for anyone adding frameworks or libraries in the future.

I'm okay with leaving the shared ones in the project file, though.

Which do you prefer?

[Eric Seidel (no email)]

Comment on attachment 168611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168611&action=review

> Source/WebKit/mac/ChangeLog:4
> +        <http://webkit.org/b/00000>

Style bot no like you!

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> (From update of attachment 168611 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168611&action=review
> 
> > Source/WebKit/mac/ChangeLog:4
> > +        <http://webkit.org/b/00000>
> 
> Style bot no like you!

Yep.  I haven't had a chance to make webkit-patch understand how to replace my bug number placeholders in ChangeLogs when it attaches the patch.

[David Kilzer (:ddkilzer)]

Committed r131350: <http://trac.webkit.org/changeset/131350>