Bug 9916

Summary:	REGRESSION: Hitting delete in an empty text form causes a crash
Product:	WebKit	Reporter:	Brady Eidson <beidson>
Component:	Forms	Assignee:	Brady Eidson <beidson>
Status:	CLOSED DUPLICATE
Severity:	Critical	Keywords:	InRadar, Regression
Priority:	P1
Version:	420+
Hardware:	Mac
OS:	OS X 10.4
URL:	http://www.google.com

Brady Eidson

Reported 2006-07-14 09:51:21 PDT

Anywhere you have an empty form if you give the form focus and press delete, ToT crashes. Seems to be something as simple as a missing nil check... Entirely reproducible anywhere - for example, the search field at www.google.com. Crash trace follows - 0 com.apple.WebCore 0x01f66ce1 WebCore::Node::renderer() const + 9 (Node.h:314) 1 com.apple.WebCore 0x01df731c WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity) + 854 (TypingCommand.cpp:343) 2 com.apple.WebCore 0x01df82d8 WebCore::TypingCommand::doApply() + 156 (TypingCommand.cpp:197) 3 com.apple.WebCore 0x01dd79a7 WebCore::EditCommand::apply() + 469 (EditCommand.cpp:227) 4 com.apple.WebCore 0x01dd7a91 WebCore::EditCommandPtr::apply() const + 81 (EditCommand.cpp:80) 5 com.apple.WebCore 0x01df7f23 WebCore::TypingCommand::deleteKeyPressed(WebCore::Document*, bool, WebCore::TextGranularity) + 363 (TypingCommand.cpp:73) 6 com.apple.WebCore 0x01cedadc -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] + 110 (WebCoreFrameBridge.mm:2172) 7 com.apple.WebKit 0x0104d0c8 -[WebHTMLView(WebHTMLViewFileInternal) _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:] + 404 (WebHTMLView.m:605) 8 com.apple.WebKit 0x0105fbb9 -[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:] + 290 (WebHTMLView.m:4554) 9 com.apple.WebKit 0x0105fc8a -[WebHTMLView deleteBackward:] + 94 (WebHTMLView.m:4569) 10 com.apple.AppKit 0x9348e35d -[NSResponder doCommandBySelector:] + 76 11 com.apple.WebKit 0x01062d5c -[WebHTMLView(WebNSTextInputSupport) doCommandBySelector:] + 148 (WebHTMLView.m:5389) 12 com.apple.AppKit 0x93483965 -[NSKeyBindingManager(NSKeyBindingManager_MultiClients) interpretEventAsCommand:forClient:] + 1932 13 com.apple.AppKit 0x93481ed1 -[NSTSMInputContext interpretKeyEvents:] + 1157 14 com.apple.AppKit 0x93481276 -[NSView interpretKeyEvents:] + 65 15 com.apple.WebKit 0x0105b477 -[WebHTMLView _interceptEditingKeyEvent:] + 246 (WebHTMLView.m:3496) 16 com.apple.WebKit 0x0105b5e5 -[WebHTMLView keyDown:] + 351 (WebHTMLView.m:3516) 17 com.apple.AppKit 0x93480ce9 -[NSWindow sendEvent:] + 7377 18 com.apple.Safari 0x000c06b8 -[Window sendEvent:] + 222 (Window.m:77) 19 com.apple.AppKit 0x93472524 -[NSApplication sendEvent:] + 5023 20 com.apple.Safari 0x00024d88 -[BrowserApplication sendEvent:] + 515 21 com.apple.AppKit 0x9339d106 -[NSApplication run] + 547 22 com.apple.AppKit 0x93391037 NSApplicationMain + 573 23 com.apple.Safari 0x000bae0d main + 333 24 com.apple.Safari 0x00002cd6 _start + 228 (crt.c:272) 25 com.apple.Safari 0x00002bf1 start + 41

Attachments
Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2006-07-14 09:56:44 PDT

In Radar, bug number 4630522

Joost de Valk (AlthA)

Comment 2 2006-07-14 09:57:52 PDT

This is a regression.

Brady Eidson

Comment 3 2006-07-14 10:18:21 PDT

Duplicate of 9905, fixed in revision 15427

Brady Eidson

Comment 4 2006-07-14 10:20:16 PDT

Verified + closing

David Kilzer (:ddkilzer)

Comment 5 2006-07-14 10:56:26 PDT

Reopen to mark duplicate.

David Kilzer (:ddkilzer)

Comment 6 2006-07-14 10:56:35 PDT

*** This bug has been marked as a duplicate of 9905 ***

Note You need to log in before you can comment on or make changes to this bug.