Bug 99130

Summary: Stop using Connection::deprecatedSend in WebConnection
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gustavo, gyuyoung.kim, menard, philn, rakuco, vestbo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2012-10-11 20:03:17 PDT
Stop using Connection::deprecatedSend in WebConnection
Attachments
Patch (24.35 KB, patch)
2012-10-11 20:06 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (26.11 KB, patch)
2012-10-11 20:12 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (26.77 KB, patch)
2012-10-11 20:49 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (27.29 KB, patch)
2012-10-11 21:23 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-11 20:06:33 PDT
Created attachment 168341 [details] Patch
WebKit Review Bot
Comment 2 2012-10-11 20:08:42 PDT
Attachment 168341 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/WebConnection.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2012-10-11 20:12:20 PDT
Created attachment 168342 [details] Patch
WebKit Review Bot
Comment 4 2012-10-11 20:14:01 PDT
Attachment 168342 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/WebConnection.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 5 2012-10-11 20:42:56 PDT
Comment on attachment 168342 [details] Patch Attachment 168342 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14254768
Anders Carlsson
Comment 6 2012-10-11 20:49:12 PDT
Created attachment 168348 [details] Patch
WebKit Review Bot
Comment 7 2012-10-11 20:51:19 PDT
Attachment 168348 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/WebConnection.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 8 2012-10-11 21:17:32 PDT
Comment on attachment 168348 [details] Patch Attachment 168348 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14254778
Anders Carlsson
Comment 9 2012-10-11 21:23:51 PDT
Created attachment 168352 [details] Patch
WebKit Review Bot
Comment 10 2012-10-11 21:27:19 PDT
Attachment 168352 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Shared/WebConnection.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 11 2012-10-11 21:41:08 PDT
Committed r131139: <http://trac.webkit.org/changeset/131139>
Note You need to log in before you can comment on or make changes to this bug.