Bug 99105 – MHTML generation crashes on www.vimeo.com

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Jay Civelli]

Calling MHTMLArchive::generateMHTMLData() on a page containing an SVG image (such as http://www.vimeo.com) causes a crasher.
This is related to 99102.

[Jay Civelli]

Created attachment 168287 [details]
Patch

[Adam Barth]

Comment on attachment 168287 [details]
Patch

This patch looks good, but we'd like a test case so we don't regress this behavior in the future.

[Jay Civelli]

Created attachment 168331 [details]
Patch

[Adam Barth]

Comment on attachment 168331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168331&action=review

Thanks.

> Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp:335
> +// Test that we don't regress https://bugs.webkit.org/show_bug.cgi?id=99105

We generally skip these sorts of comments.  The information is in the svn history.

[Build Bot]

Comment on attachment 168331 [details]
Patch

Attachment 168331 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14265141

[Adam Barth]

Comment on attachment 168331 [details]
Patch

I don't see how this patch could have broken the apple-win port.

[WebKit Review Bot]

Comment on attachment 168331 [details]
Patch

Clearing flags on attachment: 168331

Committed r131125: <http://trac.webkit.org/changeset/131125>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Anders Carlsson]

(In reply to comment #6)
> (From update of attachment 168331 [details])
> I don't see how this patch could have broken the apple-win port.

Here's why:


+        LOG_ERROR("No data for image %s", url.utf8String().data());

KURL.h has

#if USE(GOOGLEURL)
    // Getters for the parsed structure and its corresponding 8-bit string.
    const url_parse::Parsed& parsed() const { return m_url.m_parsed; }
    const CString& utf8String() const { return m_url.utf8String(); }
#endif

Maybe nobody else is building with LOG_ERROR enabled? I attempted a fix.

[Adam Barth]

> I attempted a fix.

Thanks.

[Jay Civelli]

Thanks a lot Anders for fixing the breakage!