Bug 99092

Summary: [Chromium] Improve the comment describing mainWorldScriptContext
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, gbillock, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-10-11 13:16:51 PDT
[Chromium] Improve the comment describing mainWorldScriptContext
Attachments
Patch (1.60 KB, patch)
2012-10-11 13:17 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-11 13:17:25 PDT
Created attachment 168265 [details] Patch
James Robinson
Comment 2 2012-10-11 13:20:47 PDT
Most of the callers seem a bit off - they're either injecting V8 extensions directly into this context or assuming that it's the only context that matters.
WebKit Review Bot
Comment 3 2012-10-11 13:21:35 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 4 2012-10-11 14:13:08 PDT
Comment on attachment 168265 [details] Patch Clearing flags on attachment: 168265 Committed r131095: <http://trac.webkit.org/changeset/131095>
WebKit Review Bot
Comment 5 2012-10-11 14:13:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.