Bug 9905

Summary:

REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div

Product:

WebKit

Reporter:

mitz

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

beidson, lweintraub

Priority:

Keywords:

Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

data:text/html,<div%20contenteditable></div>

Attachments:

Description	Flags
Add missing null checks	none
Add missing null checks	darin: review+

mitz

Reported 2006-07-14 01:52:26 PDT

Open the url, click inside the div and press the delete key. WebKit crashes: 0 WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity) + 2020 1 WebCore::TypingCommand::doApply() + 312 2 WebCore::EditCommand::apply() + 616 3 WebCore::TypingCommand::deleteKeyPressed(WebCore::Document*, bool, WebCore::TextGranularity) + 252 4 -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] + 92 5 -[WebHTMLView(WebHTMLViewFileInternal) _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:] + 344 6 -[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:] + 256 7 -[WebHTMLView(WebNSTextInputSupport) doCommandBySelector:] + 120 8 -[NSKeyBindingManager(NSKeyBindingManager_MultiClients) interpretEventAsCommand:forClient:] + 1700 9 -[NSTSMInputContext interpretKeyEvents:] + 1104 I believe this is a regression from one of: - r15408 <rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table - r15414 <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

Attachments
Add missing null checks (11.68 KB, patch) 2006-07-14 03:05 PDT, mitz	no flags	Details Formatted Diff Diff
Add missing null checks (11.60 KB, patch) 2006-07-14 05:12 PDT, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-07-14 03:05:51 PDT

Created attachment 9442 [details] Add missing null checks

mitz

Comment 2 2006-07-14 05:12:50 PDT

Created attachment 9444 [details] Add missing null checks Changes to the test -- removed stray comment and added missing newline.

Darin Adler

Comment 3 2006-07-14 05:31:31 PDT

Comment on attachment 9444 [details] Add missing null checks r=me

David Kilzer (:ddkilzer)

Comment 4 2006-07-14 06:08:35 PDT

Committed revision 15426.

Brady Eidson

Comment 5 2006-07-14 10:09:48 PDT

I couldn't find this bug so I filed a new one here http://bugzilla.opendarwin.org/show_bug.cgi?id=9916 It points to my radar bug about it - 4630522 Will confirm and close shortly...

David Kilzer (:ddkilzer)

Comment 6 2006-07-14 10:56:35 PDT

*** Bug 9916 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.