Bug 9903 – Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber()

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

This is a follow-up to Bug 9742.  See Bug 9742 Comment #15 for Geoffrey's comments about why this should be fixed.

Adding NeedsRadar keyword since it's a follow-up to bug 9742, which also had NeedsRadar.

[David Kilzer (:ddkilzer)]

Created attachment 9438 [details]
Patch v1

Proposed patch.  (I hope I interpreted your comment correctly, Geoff!)

[David Kilzer (:ddkilzer)]

Comment on attachment 9438 [details]
Patch v1

Oops.  I need to include the bug information in the ChangeLog!

[David Kilzer (:ddkilzer)]

Created attachment 9439 [details]
Patch v2

Now with Bugzilla bug information in the ChangeLog!

[David Kilzer (:ddkilzer)]

Note that the tests added in Bug 9742 still pass with Patch v2.

[Geoffrey Garen]

Comment on attachment 9439 [details]
Patch v2

That's right. This patch enables landing the getNumber part of my JavaScriptCore patch:

 {
     if (JSImmediate::isImmediate(this)) {
         v = JSImmediate::toDouble(this);
-        return true;
+        return JSImmediate::isNumber(this);
     }
     return downcast()->getNumber(v);

[David Kilzer (:ddkilzer)]

Committed revision 15424.

[David Kilzer (:ddkilzer)]

Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED.