Bug 99019

Summary: [GTK] REGRESSION(r131033): Favicons don't work in MiniBrowser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Mario Sanchez Prada <mario>
Status: RESOLVED FIXED    
Severity: Normal CC: mario, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal
none
Path proposal none

Carlos Garcia Campos
Reported 2012-10-11 04:00:32 PDT
Since r131033, the favicon database is not initialized by default, so we need call webkit_web_context_set_favicon_database_directory() in MiniBrowser to enable favicons again.
Attachments
Patch proposal (2.45 KB, patch)
2012-10-11 08:16 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Path proposal (1.48 KB, patch)
2012-10-11 08:53 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2012-10-11 08:16:30 PDT
Created attachment 168228 [details] Patch proposal Oneliner ready
Carlos Garcia Campos
Comment 2 2012-10-11 08:43:58 PDT
Comment on attachment 168228 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=168228&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:524 > + // Enable the favicon database, by specifying the default directory. > + webkit_web_context_set_favicon_database_directory(webkit_web_view_get_context(window->webView), NULL); > + We don't want to do this for every window, since we are sharing the web process, if would be better to do it only once in main.c before browser windows are created.
Mario Sanchez Prada
Comment 3 2012-10-11 08:53:30 PDT
Created attachment 168237 [details] Path proposal New patch addressing Carlos's comment
WebKit Review Bot
Comment 4 2012-10-11 09:37:04 PDT
Comment on attachment 168237 [details] Path proposal Clearing flags on attachment: 168237 Committed r131072: <http://trac.webkit.org/changeset/131072>
WebKit Review Bot
Comment 5 2012-10-11 09:37:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.