Bug 99017

Summary:

Web Inspector: [Styles] Colors should be "As authored" by default

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	vsevik: review+

Alexander Pavlov (apavlov)

Reported 2012-10-11 03:18:41 PDT

1. Open an instance of Chrome on a fresh profile. 2. Go to google.com. 3. Open dev tools, switch to the Console, and enter the following: $('body').style.backgroundColor = 'rgb(100, 100, 0)'; inspect($('body')) 4. Look at the color in the Style sidebar. It's shown as hex but should be shown as rgb(). Upstreaming http://code.google.com/p/chromium/issues/detail?id=154301

Attachments
Patch (1.47 KB, patch) 2012-10-11 03:23 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Patch (10.74 KB, patch) 2012-10-12 05:06 PDT, Alexander Pavlov (apavlov)	vsevik: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2012-10-11 03:23:03 PDT

Created attachment 168185 [details] Patch

WebKit Review Bot

Comment 2 2012-10-11 05:06:04 PDT

Comment on attachment 168185 [details] Patch Rejecting attachment 168185 [details] from commit-queue. New failing tests: inspector/styles/inject-stylesheet.html inspector/styles/styles-update-from-js.html inspector/styles/styles-computed-trace.html inspector/styles/lazy-computed-style.html inspector/styles/styles-overriden-properties.html inspector/elements/elements-panel-styles.html inspector/styles/variables/css-variables.html Full output: http://queues.webkit.org/results/14257494

WebKit Review Bot

Comment 3 2012-10-11 09:20:56 PDT

Comment on attachment 168185 [details] Patch Attachment 168185 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14252619 New failing tests: inspector/styles/inject-stylesheet.html inspector/styles/styles-update-from-js.html inspector/styles/styles-computed-trace.html inspector/styles/lazy-computed-style.html inspector/styles/styles-overriden-properties.html inspector/elements/elements-panel-styles.html inspector/styles/variables/css-variables.html

Build Bot

Comment 4 2012-10-11 16:04:20 PDT

Comment on attachment 168185 [details] Patch Attachment 168185 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14258731 New failing tests: inspector/styles/inject-stylesheet.html inspector/styles/styles-update-from-js.html inspector/styles/region-style-crash.html inspector/styles/styles-computed-trace.html inspector/styles/lazy-computed-style.html inspector/styles/styles-overriden-properties.html inspector/elements/elements-panel-styles.html

Alexander Pavlov (apavlov)

Comment 5 2012-10-12 05:06:54 PDT

Created attachment 168398 [details] Patch

Alexander Pavlov (apavlov)

Comment 6 2012-10-12 05:11:36 PDT

Committed r131176: <http://trac.webkit.org/changeset/131176>

Note You need to log in before you can comment on or make changes to this bug.