Bug 99015

Summary:

Web Inspector: Change "Filter" checkbox label in Network pane

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

apavlov, bweinstein, dubroy, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Vsevolod Vlasov

Reported 2012-10-11 01:54:33 PDT

Patrick Dubroy's report: I saw the CL to add a "filter" checkbox to the search bar in the Network pane (https://bugs.webkit.org/show_bug.cgi?id=93090). Glad to see it! I'd suggest we change the text to "Show only matching rows" rather than just "Filter" -- that makes it a little bit more clear what it does. Let me know if you disagree. http://code.google.com/p/chromium/issues/detail?id=143693

Attachments
Patch (2.26 KB, patch) 2012-10-11 01:56 PDT, Vsevolod Vlasov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-10-11 01:56:17 PDT

Pavel Feldman

Comment 2 2012-10-11 04:22:09 PDT

Comment on attachment 168172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168172&action=review > Source/WebCore/inspector/front-end/SearchController.js:124 > + this._filterLabelElement.textContent = WebInspector.UIString("Show only matches"); I would say "Show only matching"

Vsevolod Vlasov

Comment 3 2012-10-11 04:26:18 PDT

Let's keep it as is.

Note You need to log in before you can comment on or make changes to this bug.