| Summary: | ElementAttributeData shouldn't be managing Element's callbacks. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | andersca, cmarcelo, dglazkov, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Andreas Kling
2012-10-10 20:57:02 PDT
Created attachment 168140 [details]
poch
is gud poch! (In reply to comment #2) > is gud poch! anders pls Created attachment 168146 [details]
Rebasereded
Comment on attachment 168146 [details] Rebasereded Attachment 168146 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14250631 New failing tests: dom/html/level1/core/hc_elementremoveattribute.html dom/html/level1/core/hc_elementremoveattributenode.html dom/xhtml/level1/core/hc_attrappendchild1.xhtml dom/html/level1/core/hc_attrchildnodes2.html dom/html/level1/core/hc_attrcreatetextnode2.html dom/html/level1/core/hc_attrappendchild1.html dom/html/level1/core/hc_attrappendchild3.html dom/xhtml/level1/core/hc_attrappendchild5.xhtml dom/html/level1/core/hc_attrinsertbefore1.html dom/html/level1/core/hc_attrinsertbefore3.html dom/html/level1/core/hc_attrinsertbefore2.html dom/html/level1/core/hc_attrreplacechild1.html dom/html/level1/core/hc_attrreplacechild2.html dom/xhtml/level1/core/hc_attrcreatetextnode2.xhtml dom/html/level1/core/hc_attrinsertbefore6.html dom/html/level1/core/hc_attrappendchild5.html dom/html/level1/core/hc_elementnormalize2.html dom/html/level1/core/hc_attrsetvalue2.html dom/html/level1/core/hc_attrinsertbefore4.html dom/xhtml/level1/core/hc_attrchildnodes2.xhtml dom/html/level1/core/hc_attrnormalize.html dom/html/level1/core/hc_attrsetvalue1.html accessibility/aria-hidden-updates-alldescendants.html dom/xhtml/level1/core/hc_attrappendchild3.xhtml dom/html/level1/core/hc_attrremovechild1.html dom/xhtml/level1/core/hc_attrclonenode1.xhtml canvas/philip/tests/size.attributes.removed.html dom/html/level1/core/hc_namednodemapremovenameditem.html dom/html/level1/core/hc_attrclonenode1.html dom/html/level1/core/hc_attrcreatetextnode.html Created attachment 168259 [details]
sigh
Created attachment 168274 [details]
please merge?
Comment on attachment 168274 [details] please merge? Clearing flags on attachment: 168274 Committed r131104: <http://trac.webkit.org/changeset/131104> All reviewed patches have been landed. Closing bug. |