Bug 98976

Summary: Switch ResourceLoader::resourceData() from SharedBuffer to ResourceBuffer
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, dglazkov, gustavo, japhet, koivisto, philn, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98539    
Attachments:
Description Flags
Patch v1 - Get the EWS ball rolling
buildbot: commit-queue-
Patch v2 - Hopefully fix gtk and windows
webkit.review.bot: commit-queue-
Patch v3 - Fix crashes in layout tests andersca: review+

Description Brady Eidson 2012-10-10 17:28:26 PDT
Switch ResourceLoader::resourceData() from SharedBuffer to ResourceBuffer


This is further progress towards http://bugs.webkit.org/show_bug.cgi?id=98539
Comment 1 Brady Eidson 2012-10-10 17:32:00 PDT
Created attachment 168104 [details]
Patch v1 - Get the EWS ball rolling
Comment 2 Build Bot 2012-10-10 17:55:04 PDT
Comment on attachment 168104 [details]
Patch v1 - Get the EWS ball rolling

Attachment 168104 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14256362
Comment 3 Brady Eidson 2012-10-10 17:55:09 PDT
Created attachment 168108 [details]
Patch v2 - Hopefully fix gtk and windows
Comment 4 WebKit Review Bot 2012-10-10 20:55:57 PDT
Comment on attachment 168108 [details]
Patch v2 - Hopefully fix gtk and windows

Attachment 168108 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14254401

New failing tests:
css3/calc/transition-crash4.html
css2.1/20110323/absolute-replaced-height-007.htm
compositing/framesets/composited-frame-alignment.html
css2.1/20110323/absolute-replaced-height-025.htm
css2.1/20110323/absolute-replaced-height-014.htm
http/tests/appcache/crash-when-navigating-away-then-back.html
http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash.html
accessibility/loading-iframe-sends-notification.html
css2.1/20110323/absolute-replaced-height-011.htm
http/tests/appcache/credential-url.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
compositing/iframes/iframe-src-change.html
http/tests/appcache/different-scheme.html
http/tests/appcache/destroyed-frame.html
http/tests/css/shared-stylesheet-mutation-preconstruct.html
http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html
css2.1/20110323/absolute-replaced-height-018.htm
css2.1/20110323/absolute-replaced-height-005.htm
http/tests/eventsource/existent-eventsource-status-error-iframe-crash.html
css2.1/20110323/absolute-replaced-height-028.htm
css2.1/20110323/absolute-replaced-height-012.htm
http/tests/css/shared-stylesheet-mutation.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
css2.1/20110323/absolute-replaced-height-004.htm
css2.1/20110323/absolute-replaced-height-019.htm
css2.1/20110323/absolute-replaced-height-026.htm
compositing/overflow/iframe-inside-overflow-clipping.html
http/tests/appcache/detached-iframe.html
http/tests/inspector/resource-parameters.html
css2.1/20110323/absolute-replaced-height-021.htm
Comment 5 Brady Eidson 2012-10-10 22:17:22 PDT
(In reply to comment #4)
> (From update of attachment 168108 [details])
> Attachment 168108 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/14254401
> 
> New failing tests:
> ...

And Mac EWS seems to be spewing failures, too.  I think I know what I messed up when prepping the patch, will fix and update in the morning.
Comment 6 Brady Eidson 2012-10-11 09:31:58 PDT
Created attachment 168240 [details]
Patch v3 - Fix crashes in layout tests
Comment 7 Brady Eidson 2012-10-11 11:29:44 PDT
http://trac.webkit.org/changeset/131085