Bug 98866

Summary:

Add a test to check a step attribute works for a calendar picker

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Tools / Tests

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, yutak

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch 2	yutak: review+, yutak: commit-queue-

Kent Tamura

Reported 2012-10-09 23:37:06 PDT

Add a test to check a step attribute works for a calendar picker

Attachments
Patch (30.93 KB, patch) 2012-10-09 23:40 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 2 (30.94 KB, patch) 2012-10-09 23:55 PDT, Kent Tamura	yutak: review+ yutak: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2012-10-09 23:40:35 PDT

Created attachment 167934 [details] Patch

WebKit Review Bot

Comment 2 2012-10-09 23:44:18 PDT

Attachment 167934 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/TestExpectations:923: Did not find a test name. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:924: Did not find a test name. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:925: Did not find a test name. [test/expectations] [5] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kent Tamura

Comment 3 2012-10-09 23:55:01 PDT

Created attachment 167939 [details] Patch 2 Fix a typo. Style errors are expected.

WebKit Review Bot

Comment 4 2012-10-09 23:58:49 PDT

Attachment 167939 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/TestExpectations:923: Did not find a test name. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:924: Did not find a test name. [test/expectations] [5] LayoutTests/platform/chromium/TestExpectations:925: Did not find a test name. [test/expectations] [5] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yuta Kitamura

Comment 5 2012-10-10 00:05:24 PDT

Comment on attachment 167939 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167939&action=review Just have one comment. Looks good except for it. Please fix the issue before landing. > LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:9 > + setTimeout(function() { testRunner.notifyDone(); }, 0); I think this line can be simplified to: setTimeout(testRunner.notifyDone, 0);

Kent Tamura

Comment 6 2012-10-10 00:31:39 PDT

Comment on attachment 167939 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167939&action=review >> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:9 >> + setTimeout(function() { testRunner.notifyDone(); }, 0); > > I think this line can be simplified to: > setTimeout(testRunner.notifyDone, 0); Unfortunately it doesn't work. Probably because testRunner is an NPAPI plugin?

Kent Tamura

Comment 7 2012-10-10 00:33:49 PDT

Committed r130868: <http://trac.webkit.org/changeset/130868>

Yuta Kitamura

Comment 8 2012-10-10 00:41:34 PDT

Comment on attachment 167939 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167939&action=review >>> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:9 >>> + setTimeout(function() { testRunner.notifyDone(); }, 0); >> >> I think this line can be simplified to: >> setTimeout(testRunner.notifyDone, 0); > > Unfortunately it doesn't work. Probably because testRunner is an NPAPI plugin? That's interesting.

Note You need to log in before you can comment on or make changes to this bug.