Bug 98854

Summary: Initialize $written variable in load-and-stall.php script
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

noel gordon
Reported 2012-10-09 21:37:38 PDT
Initialize $written variable in load-sand-stall.php script
Attachments
Patch (1.20 KB, patch)
2012-10-09 21:38 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2012-10-09 21:41 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-10-09 21:38:15 PDT
Created attachment 167915 [details] Patch
noel gordon
Comment 2 2012-10-09 21:41:08 PDT
Created attachment 167916 [details] Patch
Kent Tamura
Comment 3 2012-10-09 22:41:11 PDT
Comment on attachment 167916 [details] Patch AFAIK $written is initialized as 0 implicitly. Adding the initialization is good for code readability.
noel gordon
Comment 4 2012-10-09 22:47:01 PDT
Indeed. All bets are off if you include a script in another, however :(
WebKit Review Bot
Comment 5 2012-10-09 23:02:50 PDT
Comment on attachment 167916 [details] Patch Clearing flags on attachment: 167916 Committed r130852: <http://trac.webkit.org/changeset/130852>
WebKit Review Bot
Comment 6 2012-10-09 23:02:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.