Bug 98845

Summary: GlyphPageTreeNode should use HashMap<OwnPtr>.
Product: WebKit Reporter: Andreas Kling <kling>
Component: TextAssignee: Andreas Kling <kling>
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Proposed patch
mitz: review+, buildbot: commit-queue-
Moon lander none

Description Andreas Kling 2012-10-09 19:45:14 PDT
Noticed some manual memory management going on in GlyphPageTreeNode, we should clean that up since HashMap supports OwnPtr value types these days.
Comment 1 Andreas Kling 2012-10-09 21:14:14 PDT
Created attachment 167909 [details]
Proposed patch
Comment 2 mitz 2012-10-09 21:40:36 PDT
Comment on attachment 167909 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167909&action=review

> Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp:353
> +        unsigned customFontCount = node->m_customFontCount + 1;
> +        if (customFontCount) {

Can collapse these two lines into one.
Comment 3 Build Bot 2012-10-09 21:49:29 PDT
Comment on attachment 167909 [details]
Proposed patch

Attachment 167909 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14218979
Comment 4 Andreas Kling 2012-10-09 22:04:26 PDT
Created attachment 167918 [details]
Moon lander

Scoped the local as Dan suggested + added friend declaration for the prettyprint helper in debug build.
Comment 5 WebKit Review Bot 2012-10-09 22:28:32 PDT
Comment on attachment 167918 [details]
Moon lander

Clearing flags on attachment: 167918

Committed r130850: <http://trac.webkit.org/changeset/130850>
Comment 6 WebKit Review Bot 2012-10-09 22:28:35 PDT
All reviewed patches have been landed.  Closing bug.