Summary: | GlyphPageTreeNode should use HashMap<OwnPtr>. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Text | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2012-10-09 19:45:14 PDT
Created attachment 167909 [details]
Proposed patch
Comment on attachment 167909 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=167909&action=review > Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp:353 > + unsigned customFontCount = node->m_customFontCount + 1; > + if (customFontCount) { Can collapse these two lines into one. Comment on attachment 167909 [details] Proposed patch Attachment 167909 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14218979 Created attachment 167918 [details]
Moon lander
Scoped the local as Dan suggested + added friend declaration for the prettyprint helper in debug build.
Comment on attachment 167918 [details] Moon lander Clearing flags on attachment: 167918 Committed r130850: <http://trac.webkit.org/changeset/130850> All reviewed patches have been landed. Closing bug. |