Bug 98839

Summary: Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric, gtk-ews, gustavo, jamesr, na7jun8gi, philn, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch sam: review+, buildbot: commit-queue-

Simon Fraser (smfr)
Reported 2012-10-09 18:04:58 PDT
Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
Attachments
Patch (19.19 KB, patch)
2012-10-09 18:11 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (20.88 KB, patch)
2012-10-10 09:45 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (20.87 KB, patch)
2012-10-10 09:46 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (20.90 KB, patch)
2012-10-10 10:01 PDT, Simon Fraser (smfr) 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-10-09 18:11:31 PDT
Created attachment 167890 [details] Patch
Build Bot
Comment 2 2012-10-09 19:29:46 PDT
Comment on attachment 167890 [details] Patch Attachment 167890 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14250146
Early Warning System Bot
Comment 3 2012-10-09 19:44:48 PDT
Comment on attachment 167890 [details] Patch Attachment 167890 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14215982
Early Warning System Bot
Comment 4 2012-10-09 20:16:57 PDT
Comment on attachment 167890 [details] Patch Attachment 167890 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14245339
Gyuyoung Kim
Comment 5 2012-10-09 20:23:25 PDT
Comment on attachment 167890 [details] Patch Attachment 167890 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14250158
Sam Weinig
Comment 6 2012-10-09 21:20:56 PDT
Comment on attachment 167890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167890&action=review Looks good, but more things need to build. > Source/WebCore/platform/graphics/GraphicsLayer.cpp:695 > + WTF::String output = layer->layerTreeAsText(LayerTreeAsTextDebug | LayerTreeAsTextIncludeVisibleRects); Not new, but the WTF:: here is not necessary. > Source/WebCore/platform/graphics/GraphicsLayer.h:439 > + static void writeIndent(TextStream&, int /*indent*/); There is no reason to comment out the word indent here.
Simon Fraser (smfr)
Comment 7 2012-10-10 09:45:25 PDT
Created attachment 168016 [details] Patch
Simon Fraser (smfr)
Comment 8 2012-10-10 09:46:45 PDT
Created attachment 168017 [details] Patch
Gyuyoung Kim
Comment 9 2012-10-10 10:00:52 PDT
Comment on attachment 168017 [details] Patch Attachment 168017 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14254221
Simon Fraser (smfr)
Comment 10 2012-10-10 10:01:02 PDT
Created attachment 168021 [details] Patch
Build Bot
Comment 11 2012-10-10 10:27:09 PDT
Comment on attachment 168021 [details] Patch Attachment 168021 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14245581
kov's GTK+ EWS bot
Comment 12 2012-10-10 10:50:04 PDT
Comment on attachment 168021 [details] Patch Attachment 168021 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14260089
Simon Fraser (smfr)
Comment 13 2012-10-10 10:50:58 PDT
http://trac.webkit.org/changeset/130927 This will break the Windows build with a link error, which I'll use to get the right mangled symbol to export.
Note You need to log in before you can comment on or make changes to this bug.