Bug 9883

Summary:

REGRESSION: NativePopups don't work correctly in some forum software

Product:

WebKit

Reporter:

Jon <jon>

Component:

Forms

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Major

CC:

adele

Priority:

Keywords:

InRadar, NeedsReduction, Regression

Version:

420+

Hardware:

Mac (PowerPC)

OS:

OS X 10.4

URL:

http://forums.macnn.com

Attachments:

Description	Flags
patch with detailed change log and a layout test	sullivan: review+

Jon

Reported 2006-07-12 17:36:28 PDT

When trying to select a forum through the popup menus at the MacNN forums or the InsideMacGames forums, the forum selected does not match the forum loaded. The menu items selected don't match the links they load.

Attachments
patch with detailed change log and a layout test (15.58 KB, patch) 2006-07-14 21:42 PDT, Darin Adler	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2006-07-12 20:56:43 PDT

Confirmed using locally-built WebKit r15391 with Safari 2.0.4 (419.3) on Mac OS X 10.4.7 (8J135/PowerPC).

David Kilzer (:ddkilzer)

Comment 2 2006-07-12 21:06:03 PDT

Works with production Safari 2.0.4 (419.3) on Mac OS X 10.4.7 (8J135/PowerPC). Steps to reproduce: 1. Open URL: http://forums.macnn.com/ 2. Click on "Power Mac" forum in list. 3. Scroll down to the bottom of the page, then scroll right. 4. Select a new forum in the "Forum Jump" pop-up list, like "PowerBook & MacBook Pro". Expected results: You are taken to the "PowerBook & MacBook Pro" forum. Actual results: You are taken to the "iBook & MacBook" forum, two items below where you should be. Notes: It looks like the two OPTGROUP labels above "PowerBook & MacBook Pro" are each causing off-by-one errors, causing the value to be sent for two items below the one selected above.

Alice Liu

Comment 3 2006-07-14 17:05:10 PDT

<rdar://problem/4631821>

Darin Adler

Comment 4 2006-07-14 21:42:05 PDT

Created attachment 9462 [details] patch with detailed change log and a layout test

John Sullivan

Comment 5 2006-07-14 21:47:15 PDT

Comment on attachment 9462 [details] patch with detailed change log and a layout test There's a wordo in the ChangeLog ("because" for "before"). And I don't know if "to ... index" is a typo, a placeholder, or terminology that I'm unfamiliar with. But the change itself looks good.

Darin Adler

Comment 6 2006-07-15 06:24:08 PDT

(In reply to comment #5) > (From update of attachment 9462 [details] [edit]) > And I don't know if > "to ... index" is a typo, a placeholder, or terminology that I'm unfamiliar > with. That was my failed attempt at a joke. I was trying to introduce a sarcastic pause. Convert to a list index for the purposes of indexing into the list! I'll try to write something one can understand instead.

Darin Adler

Comment 7 2006-07-15 08:08:26 PDT

Committed revision 15453.

Note You need to log in before you can comment on or make changes to this bug.