|Summary:||Text Autosizing: Counteract funky window sizing on Android.|
|Product:||WebKit||Reporter:||John Mellor <johnme>|
|Component:||New Bugs||Assignee:||John Mellor <johnme>|
|Severity:||Normal||CC:||abarth, aelias, benjamin, eric, skyostil, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description John Mellor 2012-10-09 11:44:27 PDT
Text Autosizing: Counteract funky window sizing on Android.
Comment 3 Alexandre Elias 2012-10-09 12:04:18 PDT
I would have preferred pushing down a setting so that we can switch between the modes with only a Chromium-side change; this will be a loose end. That said if this is one of the last things blocking the text autosizing completion we can land and fix later.
Comment 4 John Mellor 2012-10-09 12:21:43 PDT
(In reply to comment #3) > I would have preferred pushing down a setting so that we can switch between the modes with only a Chromium-side change; this will be a loose end. That said if this is one of the last things blocking the text autosizing completion we can land and fix later. Yeah, this is the last thing blocking us from turning Text Autosizing on in Chrome for Android. By pushing down a setting, do you mean exposing WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor to WebCore? Or some separate setting?
Comment 5 Alexandre Elias 2012-10-09 12:25:20 PDT
Yes, WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor is essentially equivalent to this new USE define, so we would be better to use that instead.
Comment 6 WebKit Review Bot 2012-10-09 13:42:51 PDT
Comment on attachment 167806 [details] Patch Rejecting attachment 167806 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 150 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 150. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14197033
Comment 7 Adam Barth 2012-10-09 14:10:50 PDT
Comment on attachment 167806 [details] Patch This code already has a m_document, so it shouldn't have any trouble finding Settings. Perhaps we should use that instead.
Comment 9 Alexandre Elias 2012-10-09 16:45:07 PDT
Uploaded a patch using applyPageScaleFactorInCompositor. It's essentially the same thing as the other setting except for being in WebCore and I plan to flip them simultaneously.
Comment 10 Adam Barth 2012-10-09 17:18:03 PDT
Comment on attachment 167876 [details] Patch Ok. I would have added a comment explaining the connection between applyPageScaleFactorInCompositor and the bug in the units of the window size.
Comment 11 Alexandre Elias 2012-10-10 00:17:07 PDT
Comment on attachment 167876 [details] Patch I'll cq+ without the comment to unblock johnme@ for his remaining cleanup. I'll go back eventually to remove all these if() statements anyway.
Comment 12 WebKit Review Bot 2012-10-10 00:23:22 PDT
Comment on attachment 167876 [details] Patch Clearing flags on attachment: 167876 Committed r130866: <http://trac.webkit.org/changeset/130866>
Comment 13 WebKit Review Bot 2012-10-10 00:23:26 PDT
All reviewed patches have been landed. Closing bug.