Bug 98799

Summary: Web Inspector: remove protocol-externs.js temp file after compile-front-end.py
Product: WebKit Reporter: johnjbarton <johnjbarton>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

johnjbarton
Reported 2012-10-09 11:20:58 PDT
so we don't have do it by hand
Attachments
Patch (1.72 KB, patch)
2012-10-09 11:26 PDT, johnjbarton 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2012-12-12 09:58 PST, johnjbarton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
johnjbarton
Comment 1 2012-10-09 11:26:34 PDT
Created attachment 167795 [details] Patch
johnjbarton
Comment 2 2012-12-11 10:31:32 PST
How can we move this to the next step?
WebKit Review Bot
Comment 3 2012-12-12 00:16:53 PST
Comment on attachment 167795 [details] Patch Rejecting attachment 167795 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15285192
Vsevolod Vlasov
Comment 4 2012-12-12 00:25:06 PST
Could you please rebaseline the patch and add "Reviewed by .." line in it?
johnjbarton
Comment 5 2012-12-12 09:58:45 PST
Created attachment 179073 [details] Patch
WebKit Review Bot
Comment 6 2012-12-12 11:46:37 PST
Comment on attachment 179073 [details] Patch Clearing flags on attachment: 179073 Committed r137496: <http://trac.webkit.org/changeset/137496>
WebKit Review Bot
Comment 7 2012-12-12 11:46:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.