Bug 98727

Summary: Should reject invalid dates constructed with multiple fields UI
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mifenton, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98226    
Attachments:
Description Flags
Patch
none
Patch 2 morrita: review+, tkent: commit-queue-

Kent Tamura
Reported 2012-10-09 00:28:31 PDT
In input[type=date] with multiple fields UI, we allow users to set day-of-month value to 1-31 regardless of the month value. So users can construct an invalid date such as "2012-02-31". We should sanitize such values.
Attachments
Patch (13.01 KB, patch)
2012-10-09 00:31 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (17.29 KB, patch)
2012-10-09 02:43 PDT, Kent Tamura 		morrita: review+
tkent: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-09 00:31:09 PDT
Created attachment 167701 [details] Patch
Hajime Morrita
Comment 2 2012-10-09 01:02:05 PDT
Comment on attachment 167701 [details] Patch Could you make the test somehow more readable? It's full of boilerplate and it's hard to read these key sequences to see what should happen.
WebKit Review Bot
Comment 3 2012-10-09 01:18:10 PDT
Comment on attachment 167701 [details] Patch Attachment 167701 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14214637 New failing tests: fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html
Kent Tamura
Comment 4 2012-10-09 02:18:33 PDT
(In reply to comment #2) > (From update of attachment 167701 [details]) > Could you make the test somehow more readable? It's full of boilerplate and it's hard to read these key sequences to see what should happen. It's hard to improve the test result readability. So I'll add comments to the .html.
Kent Tamura
Comment 5 2012-10-09 02:43:43 PDT
Created attachment 167717 [details] Patch 2 - Added comments - Update month-multiple-fields-keybaord-events.html
Hajime Morrita
Comment 6 2012-10-09 18:32:48 PDT
Comment on attachment 167717 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167717&action=review > LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:82 > +keyDown('downArrow'); // -> [09]/29/2012 [08]?
Kent Tamura
Comment 7 2012-10-09 18:35:15 PDT
Comment on attachment 167717 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=167717&action=review >> LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:82 >> +keyDown('downArrow'); // -> [09]/29/2012 > > [08]? You're right.
Kent Tamura
Comment 8 2012-10-09 18:40:08 PDT
Committed r130835: <http://trac.webkit.org/changeset/130835>
Note You need to log in before you can comment on or make changes to this bug.