Summary: | ScrollingCoordinator is a hot mess of if-defs | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||||||||||||
Component: | Platform | Assignee: | Beth Dakin <bdakin> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | andersca, bdakin, dglazkov, gyuyoung.kim, jamesr, laszlo.gombos, peter+ews, rakuco, simon.fraser, tonikitoo, webkit.review.bot | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Beth Dakin
2012-10-08 16:00:42 PDT
Created attachment 167919 [details]
Patch
Created attachment 167921 [details]
Patch
Comment on attachment 167921 [details] Patch Attachment 167921 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14229880 Comment on attachment 167921 [details] Patch Attachment 167921 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14221994 Comment on attachment 167921 [details] Patch Attachment 167921 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14254051 Created attachment 168047 [details]
Patch
Not sure why Chromium isn't building…
Comment on attachment 168047 [details] Patch Attachment 168047 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14253324 Comment on attachment 168047 [details] Patch Attachment 168047 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14244700 Created attachment 168142 [details]
Patch
Comment on attachment 168142 [details] Patch Attachment 168142 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14252458 Comment on attachment 168142 [details] Patch Attachment 168142 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14252459 Sorry you're having trouble with the chromium build. I'll patch this in locally and see if I can get it up and running. The cleanup looks great! (In reply to comment #12) > Sorry you're having trouble with the chromium build. I'll patch this in locally and see if I can get it up and running. The cleanup looks great! Thanks, James! I knew I would be doing this dance with the ews bots since I wrote so much code without compiling it locally. I have a possible fix for the latest build errors. WIll post now. Created attachment 168248 [details]
Patch
Created attachment 168251 [details]
Patch
Attached a patch that compiles on chromium, but I had some merge conflicts in the WebCore project.pbxproj so it's not complete. Hope it helps! (In reply to comment #16) > Attached a patch that compiles on chromium, but I had some merge conflicts in the WebCore project.pbxproj so it's not complete. Hope it helps! Sweet, thanks! Created attachment 168258 [details]
Patch
Okay, I *think* I merged everything properly. Here's another go for the bots.
Comment on attachment 168258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168258&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.h:110 > + // These virtual functions are currently unique to the threaded scrolling architecture, and they are > + // their meaningful implementations are in ScrollingCoordinatorMac. Parse error. Thanks Anders! http://trac.webkit.org/changeset/131137 |