| Summary: | Replace 2 uses of updateLogicalHeight with computeLogicalHeight | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | donggwan.kim, eric, fmalita, mifenton, ojan, pdr, schenney, tkent, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 96804 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2012-10-08 11:42:53 PDT
Created attachment 167576 [details]
Patch
Comment on attachment 167576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167576&action=review > Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:115 > +void RenderSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit logicalTop, LogicalExtentComputedValues& computedValues) const I assume foreignObject is forced into horizontal-tb? Not really related to this patch, but I feel like we should have asserts at the top of all the layout/computeLogicalHeight/computeLogicalWidth methods for RenderObject subclasses that don't support vertical writing mode. Either that, or a FIXME to support it. Comment on attachment 167576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167576&action=review >> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:115 >> +void RenderSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit logicalTop, LogicalExtentComputedValues& computedValues) const > > I assume foreignObject is forced into horizontal-tb? > > Not really related to this patch, but I feel like we should have asserts at the top of all the layout/computeLogicalHeight/computeLogicalWidth methods for RenderObject subclasses that don't support vertical writing mode. Either that, or a FIXME to support it. Oh, no, they're not forced into horizontal-tb. Let me see if I can make a test case for that. Created attachment 167584 [details]
Patch for landing
(In reply to comment #3) > Oh, no, they're not forced into horizontal-tb. Let me see if I can make a test case for that. Actually, I can't seem to get an inline svg to render in vertical-rl. I'm not sure what's supposed to happen here. Comment on attachment 167584 [details] Patch for landing Clearing flags on attachment: 167584 Committed r130686: <http://trac.webkit.org/changeset/130686> All reviewed patches have been landed. Closing bug. |