Bug 9866

Summary: REGRESSION: Repro crash from mangleme using iframe, only from server
Product: WebKit Reporter: jonathanjohnsson
Component: DOMAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, ddkilzer
Priority: P1 Keywords: HasReduction, InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
Crash log
none
Patch darin: review+

jonathanjohnsson
Reported 2006-07-12 01:30:48 PDT
I found another crash using the mangleme script. WebKit only crashes when the file is on the server (I used Apache 1.3, don't know if it is server specific). Latest released Safari is not affected. The crash reduces to the simple line <IFRAME SRC=file: > The nightly used was revision 15375.
Attachments
Test case (19 bytes, text/html)
2006-07-12 01:31 PDT, jonathanjohnsson 		no flags
Details
Crash log (21.03 KB, text/plain)
2006-07-12 01:33 PDT, jonathanjohnsson 		no flags
Details
Patch (3.13 KB, patch)
2006-07-14 17:06 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jonathanjohnsson
Comment 1 2006-07-12 01:31:38 PDT
Created attachment 9391 [details] Test case
jonathanjohnsson
Comment 2 2006-07-12 01:33:10 PDT
Created attachment 9392 [details] Crash log
Darin Adler
Comment 3 2006-07-12 09:01:21 PDT
This regression was caused by r15170, the change for <http://bugzilla.opendarwin.org/show_bug.cgi?id=3581>. We're trying to dereference null. #1  0x01fe01e4 in WebCore::HTMLIFrameElement::attach (this=0x19ba11e0) at /Safari/OpenSource/WebCore/html/HTMLIFrameElement.cpp:154 154             renderPart->setWidget(contentFrame()->view()); (gdb) p contentFrame() $1 = (Frame *) 0x0
Alice Liu
Comment 4 2006-07-14 15:32:08 PDT
<rdar://problem/4631561>
Anders Carlsson
Comment 5 2006-07-14 17:06:25 PDT
Created attachment 9456 [details] Patch
Darin Adler
Comment 6 2006-07-14 18:41:25 PDT
Comment on attachment 9456 [details] Patch r=me
Anders Carlsson
Comment 7 2006-07-15 01:59:20 PDT
Committed revision 15450.
Note You need to log in before you can comment on or make changes to this bug.