| Summary: | Add a "non-zero" flag for CSSParser::validUnit() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tab Atkins <tabatkins> | ||||||
| Component: | CSS | Assignee: | Tab Atkins <tabatkins> | ||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||
| Severity: | Normal | CC: | bfulgham, cmarcelo, macpherson, menard, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 65159 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tab Atkins
2012-10-05 14:32:08 PDT
Created attachment 167384 [details]
Patch
Created attachment 167435 [details]
Patch
Whoops, sorry for the noise. This patch is identical to the previous. I hadn't refreshed the bug page since before I uploaded the first patch, so I didn't realize it was already committed. :/ Anyway, r+ and cq+ please. ^_^ Comment on attachment 167435 [details] Patch It seems like for such a simple change we might want to just roll this into bug 65159. I also probably would have called this FPositive since non-zero could be negative, no? Okay, I wasn't sure what the protocol was for this kind of thing. I went with NonZero rather than Positive because it might be useful to have non-zero behavior specifically. However, I don't know of any case where that's true, so I might as well just rename it and shorten its usage. Okay, so I'll fold this into bug 65159. Comment on attachment 167435 [details] Patch Turning off cq? to see if this gets submitted as part of bug 65159 instead. If so, I'll just cancel this bug out entirely. Comment on attachment 167435 [details]
Patch
This code is no longer relevant.
|