Summary: | Clipboard::types() should return an ordered collection. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | UI Events | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, gyuyoung.kim, haraken, japhet, mifenton, peter+ews, rafael.lobo, rakuco, rwlbuis, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2012-10-05 12:29:56 PDT
Created attachment 167368 [details]
Patch?
Comment on attachment 167368 [details] Patch? Attachment 167368 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14179576 Comment on attachment 167368 [details] Patch? Attachment 167368 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14179582 Created attachment 167372 [details]
Patch??
Awesome patch! Incredible how we ever returned them ordered by insertion. :-) Comment on attachment 167372 [details]
Patch??
Why not Vector<String>? I can’t imagine that the types vector ever gets so long that the hash table is an important optimization.
Comment on attachment 167372 [details] Patch?? Clearing flags on attachment: 167372 Committed r130588: <http://trac.webkit.org/changeset/130588> All reviewed patches have been landed. Closing bug. |