Bug 98544

Summary:

[GTK] Add runtime option for drawing debug borders of AC layers

Product:

WebKit

Reporter:

ChangSeok Oh <kevin.cs.oh>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	pnormand: review-, pnormand: commit-queue-

ChangSeok Oh

Reported 2012-10-05 11:53:05 PDT

This bug is for adding runtime option, --enable-debug-borders for WK1. I believe this is convenient for AC debugging.

Attachments
Patch (5.47 KB, patch) 2012-10-05 12:10 PDT, ChangSeok Oh	no flags	Details Formatted Diff Diff
Patch (5.46 KB, patch) 2012-10-25 09:42 PDT, ChangSeok Oh	pnormand: review- pnormand: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

ChangSeok Oh

Comment 1 2012-10-05 12:10:58 PDT

Created attachment 167365 [details] Patch

WebKit Review Bot

Comment 2 2012-10-05 12:13:00 PDT

Attachment 167365 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/webkit/webkitwebsettings.cpp:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:869: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:871: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:872: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

ChangSeok Oh

Comment 3 2012-10-25 09:42:55 PDT

Created attachment 170674 [details] Patch

ChangSeok Oh

Comment 4 2012-10-25 09:45:08 PDT

Comment on attachment 170674 [details] Patch Above warnings seems false, because indentations of this change are completely same with the upper option.

WebKit Review Bot

Comment 5 2012-10-25 09:45:16 PDT

Attachment 170674 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/webkit/webkitwebsettings.cpp:867: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkitwebsettings.cpp:869: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 6 2013-04-12 12:25:58 PDT

Comment on attachment 170674 [details] Patch Looks good but please add a new unit-test in the websettings test.

ChangSeok Oh

Comment 7 2013-04-25 03:08:14 PDT

(In reply to comment #6) > (From update of attachment 170674 [details]) > Looks good but please add a new unit-test in the websettings test. Thanks for your interest :) But now we can see the debug-borders by setting environment value "WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS" http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp#L3569 So let me close this bug. :)

Note You need to log in before you can comment on or make changes to this bug.